-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests added #210
base: main
Are you sure you want to change the base?
e2e tests added #210
Conversation
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs rebase
package.json
Outdated
}, | ||
"dependencies": { | ||
"@kubernetes/client-node": "^0.22.0", | ||
"@podman-desktop/api": "^1.12.0", | ||
"fs-extra": "^11.2.0", | ||
"got": "^14.4.2", | ||
"js-yaml": "^4.1.0" | ||
"js-yaml": "^4.1.0", | ||
"node-fetch": "^2.6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in devDependencies ?
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
…x-ext into e2e-tests
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
…x-ext into e2e-tests
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite ok, except the review comments. but e2e tests are overal ok!
ae64397
to
bcdace9
Compare
Signed-off-by: xbabalov <t.babalova.17@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a PR should be split in 2 parts: switch to module then add E2E tests
@jeffmaury @xbabalov First we need to switch to ES modules and then we could merge this PR. I will open an issue. |
Added e2e tests that cover extension installation and handling.
Issues: #199 and #201