fix: show success notification when pushing multi-resource editor (#710) #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dhat-developer#710) Signed-off-by: Andre Dietisheim <adietish@redhat.com>
|
|
@sbouchet, @lgrossma: I'd love to get feedback on how this change feels for an end-user (a test-document with a deployment and a service is in the issue). Does it feel right, odd? Is it possible for you to test it and tell me, please? To me the cases where a single resource in a multi-resource document is modified and pushed is ok. More questionable is when you have multiple notifications are displayed: ex. |
|
@lgrossma: did you find the time to test this, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #710