Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console plugin job for OpenShift Pipelines #296

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

strangiato
Copy link
Contributor

Create a new job that enables the console plugin for the OpenShift Pipelines operator.

Copy link
Collaborator

@pittar pittar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pittar pittar merged commit ee88607 into redhat-cop:main Apr 30, 2024
4 checks passed
@strangiato strangiato deleted the pipeline-console-plugin branch April 30, 2024 20:44
@raffaelespazzoli
Copy link

raffaelespazzoli commented Apr 30, 2024

there is no need to use a job, you can do this declaratively, see here for example: https://github.com/raffaelespazzoli/oai/blob/main/components/openshift-config/console-patch.yaml

@pittar
Copy link
Collaborator

pittar commented Apr 30, 2024

@raffaelespazzoli , that would require you to know all the plugins you are adding.
I think both ways are valid. If you want to add new operators (gitops and pipelines) and have each enable their own console plugins, the Job is good.
If you want to manage the Console CRD yourself and add all of the console plugins that way, I think that is fine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants