This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add ELB Listener Rules object #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboulineau
force-pushed
the
add-listener-elb
branch
from
555944f
to
c3ea37f
Compare
der-eismann
reviewed
Feb 23, 2024
resources/elbv2-listenerrule.go
Outdated
Comment on lines
16
to
18
| elb *elbv2.LoadBalancer | ||
| listener *elbv2.Listener | ||
| rule *elbv2.Rule |
There was a problem hiding this comment.
Do we really need to store whole objects here? Looks like we're only using ARNs and names from the resources.
There was a problem hiding this comment.
It's indeed not required, I've changed to only store what's necessary.
vboulineau
force-pushed
the
add-listener-elb
branch
from
c3ea37f
to
6d68b34
Compare
der-eismann
approved these changes
Feb 29, 2024
bjoernhaeuser
approved these changes
Feb 29, 2024
bjfish25
added a commit
to Optum/aws-nuke
that referenced
this pull request
Jun 21, 2024
* Bump the golang group with 1 update (rebuy-de#1188) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the golang group with 1 update (rebuy-de#1191) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add release note config (rebuy-de#1192) * Add support for Redshift Serverless namespaces, snapshots and workgroups. (rebuy-de#1194) * feat: Adding Cloudfront response headers policies (rebuy-de#1140) * Bump the golang group with 1 update (rebuy-de#1195) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add ELB Listener Rules object (rebuy-de#1193) Co-authored-by: Philipp Trulson <der-eismann@users.noreply.github.com> * Bump the golang group with 2 updates (rebuy-de#1201) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the golang group with 1 update (rebuy-de#1205) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add manual trigger to workflow (rebuy-de#1208) * Bump the golang group across 1 directory with 2 updates (rebuy-de#1217) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/aws/aws-sdk-go from 1.51.31 to 1.52.3 in the golang group (rebuy-de#1220) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump the golang group across 1 directory with 2 updates (rebuy-de#1227) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github.com/aws/aws-sdk-go from 1.53.10 to 1.53.15 in the golang group (rebuy-de#1229) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add cloudformationiface mock (#19) --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Trulson <der-eismann@users.noreply.github.com> Co-authored-by: Maarten Dirkse <maarten.dirkse@gmail.com> Co-authored-by: Oliver Fletcher <oliver.fletcher@rackspace.com> Co-authored-by: Vincent Boulineau <58430298+vboulineau@users.noreply.github.com> Co-authored-by: Bradley Fisher <brad.fisher25@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ELB Listener Rule resource.
It cannot be cleaned up just by using Cloud Control as it requires to list ELB -> Listener -> ListenerRule