helm: add env variable for session inactivity to server #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
=======================================
Coverage 18.90% 18.90%
=======================================
Files 26 26
Lines 2195 2195
=======================================
Hits 415 415
Misses 1780 1780 |
giuseppe-steduto
force-pushed
the
server-max-inactivity-time-env
branch
from
01cb222
to
9eaa2b9
Compare
mdonadoni
reviewed
Jun 30, 2023
CHANGES.rst
Outdated
| @@ -5,6 +5,7 @@ Version 0.9.1 (UNRELEASED) | |||
| -------------------------- | |||
|
|
|||
| - Administrators: | |||
| - Adds configuration environment variable ``reana_server.environment.REANA_INTERACTIVE_SESSION_MAX_INACTIVITY_PERIOD`` to set a limit in days for the maximum inactivity period of interactive sessions after which they will be closed. | |||
There was a problem hiding this comment.
I think this can be skipped, it is just an internal change so I feel like there is no need to add it to the CHANGES. In any case, CHANGES.rst are checked and fixed before any stable release.
giuseppe-steduto
force-pushed
the
server-max-inactivity-time-env
branch
2 times, most recently
from
e605356
to
78cb8b1
Compare
Adds an env variable that contains the maximum number of days for which an interactive session can stay inactive before being automatically closed. Closes reanahub/reana-client#657
mdonadoni
force-pushed
the
server-max-inactivity-time-env
branch
from
78cb8b1
to
6f86e14
Compare
mdonadoni
approved these changes
Jul 12, 2023
|
Looking good! I have rebased the PR and merged it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an env variable that contains the maximum number of days for which an interactive session can stay inactive before being automaticallly closed.
Closes reanahub/reana-client#657