Fix reporting SPLATDI001 for non-DI Register calls (#240) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 92.32% 93.52% +1.19%
==========================================
Files 16 16
Lines 469 463 -6
Branches 50 51 +1
==========================================
Hits 433 433
+ Misses 22 16 -6
Partials 14 14 ☔ View full report in Codecov by Sentry. |
glennawatson
approved these changes
Sep 25, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a check that makes sure
Register*calls on classes that aren'tSplat.SplatRegistrationsaren't counted as valid method targets for source generation.What is the current behavior?
#240
What is the new behavior?
SPLATDI001only reported on calls toSplat.SplatRegistrations.Register*What might this PR break?
Hopefully nothing
Please check if the PR fulfills these requirements
Other information:
I'm not exactly sure from a cursory glance if Splat.DI.SG is meant to look at registration calls from other DI providers or not. If so, please let me know if it would be better to check for a specific interface instead.