-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windows): add New Architecture support #1147
Draft
Yajur-Grover
wants to merge
48
commits into
react-native-async-storage:main
Choose a base branch
from
Yajur-Grover:yg-fabric-windows-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 42 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
b3739e6
upgrade to work on 0.74
Yajur-Grover 73e701f
codegen config changes
Yajur-Grover b231d74
changes from codegen-windows
Yajur-Grover 7967f29
rename example to sample and run the cpp-lib template
Yajur-Grover 7e5116e
add method stubs for turbomodule
Yajur-Grover beb94d5
fix where codegen runs
Yajur-Grover 10b538b
bump RNTA and fix package.json
Yajur-Grover 36a9635
fix project to include correct module code
Yajur-Grover f289477
revert sample back to example
Yajur-Grover 50e5255
register turbomodules and fix config issues
Yajur-Grover 66c9429
re-add paper dependencies
Yajur-Grover b01454d
fix pch.h and untrack ExperimentalFeatures.props
Yajur-Grover 1ea1df7
remove unused asyncstorage files
Yajur-Grover 015b4ab
remove unused testapp directories
Yajur-Grover 6f1d52f
revert some changes
Yajur-Grover 5e055bc
revert according to feedback
Yajur-Grover a794eb1
delete more unused files
Yajur-Grover f1fc1d4
address comments
Yajur-Grover 8387705
fix packageprovider
Yajur-Grover 123b3fd
fix turbomodule usage
Yajur-Grover 8dade8c
fix typos
Yajur-Grover 8acb3b0
revert changes
Yajur-Grover e50e5e1
revert some changes
Yajur-Grover be17698
remove default-storage/windows/packages/*
Yajur-Grover 3782d55
revert gradlew
Yajur-Grover 539a4c1
revert bad ios change
Yajur-Grover 00913a6
revert bad macos change
Yajur-Grover e49a0ef
revert yarn.lock
Yajur-Grover 35b24a1
remove resource.h and ReactNativeAsyncStorage.rc
Yajur-Grover 452ed6f
remove unnecessary dependencies
Yajur-Grover dabd92a
address feedback
Yajur-Grover 66e0c92
run yarn format
Yajur-Grover ad9ce4d
remove unused imports
Yajur-Grover 456d9fa
revert packageprovider.h
Yajur-Grover b6bfb3b
update WindowsSDK versions
Yajur-Grover b9f2e55
test updated yarn.lock
Yajur-Grover dd5b0fb
change call to asyncstoragetestsupport
Yajur-Grover eef71c1
test props and targets import changes
Yajur-Grover ce96c4b
import props
Yajur-Grover ee87b26
set rnw to 0.75.5 min and fix vcxproj
Yajur-Grover f79f198
update AsyncStorageTestSupport declaration
Yajur-Grover ef227e7
remove unused packageproviders
Yajur-Grover a1d931c
update props and targets files checks
Yajur-Grover 9bc5354
apply changes from feedback
Yajur-Grover 67526ce
fix formatting
Yajur-Grover c3c8874
update tests
Yajur-Grover 8099d49
format
Yajur-Grover dd1dbac
fix error conditions
Yajur-Grover File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tido64 is this change a good way to make sure RNTA uses 0.75.5, instead of publishing this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to add a resolution override. You can bump the package in
yarn.lock
. Since it's already been bumped, you can remove this entry only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.