postprocess: hailo: Handle multiple scaler crops on the ISP outputs #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change for rpi::ScalerCrops changes the behaviour of how crops are advertised - we now need a non-RAW output stream to be configured to return the available crop control. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Add a HailoPostProcessingStage::ConvertInferenceCoordinates() helper that converts from the inference (low res) image co-ordinate space to the main image space, accounting for different scaler crops. Fixup the Yolo inference and pose estimation stages to use this new helper. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Add a new command line argument "--lores-par" that when set, preserves the 1:1 aspect ratio of the low res stream. This is only possible on the PiSP platform. The default behaviour is to have this switch disabled, allowing for identical behaviour betwen VC4 and PiSP platforms. This requires the use of the rpi::ScalerCrops vendor control. This switch can also be triggered via the "rpicam-apps.lores.par" key in the postprocessing JSON file. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a HailoPostProcessingStage::ConvertInferenceCoordinates() helper that converts from the inference (low res) image co-ordinate space to the main image space, accounting for different scaler crops.
Fixup the Yolo inference and pose estimation stages to use this new helper.