Skip to content

Commit

Permalink
Adjust Methods - useComputedProperties (#1873)
Browse files Browse the repository at this point in the history
* Adjust Methods - useComputedProperties

* Adjust ActionTest
  • Loading branch information
lrljoe authored Aug 23, 2024
1 parent 46d2752 commit 7aa4268
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 12 deletions.
8 changes: 0 additions & 8 deletions docs/misc/actions.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@ Actions is a beta feature, that allows for the creation of Action Buttons that a

This is NOT recommended for production use at this point in time.

## Usage
To use "Actions", while it is in beta, you must include the following Trait in your table:
```php
use Rappasoft\LaravelLivewireTables\Traits\WithActions;
```

Once out of beta, this will not be required.

## Component Available Methods
### setActionWrapperAttributes

Expand Down
2 changes: 1 addition & 1 deletion src/Traits/ComponentUtilities.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ trait ComponentUtilities

protected array $extraWithAvgs = [];

protected bool $useComputedProperties = false;
protected bool $useComputedProperties = true;

/**
* Set any configuration options
Expand Down
2 changes: 1 addition & 1 deletion src/Traits/HasAllTraits.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ trait HasAllTraits
use WithTableHooks;
use WithLoadingPlaceholder;
use ComponentUtilities,
//WithActions,
WithActions,
WithData,
WithColumns,
WithSorting,
Expand Down
2 changes: 1 addition & 1 deletion src/Traits/WithSorting.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ trait WithSorting

public string $defaultSortingLabelDesc = 'Z-A';

protected function queryStringWithSorting(): array
public function queryStringWithSorting(): array
{
if ($this->queryStringIsEnabled() && $this->sortingIsEnabled()) {
return [
Expand Down
2 changes: 1 addition & 1 deletion tests/Views/Actions/ActionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ public function test_can_check_has_actions(): void
{
use \Rappasoft\LaravelLivewireTables\Traits\WithActions;

public function actions()
public function actions(): array
{
return [
\Rappasoft\LaravelLivewireTables\Views\Actions\Action::make('Test Edit 1')
Expand Down

0 comments on commit 7aa4268

Please sign in to comment.