Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non-blocking ucxx::Endpoint::close() #232

Draft
wants to merge 31 commits into
base: branch-0.40
Choose a base branch
from
Draft

Improve non-blocking ucxx::Endpoint::close() #232

wants to merge 31 commits into from

Conversation

pentschev
Copy link
Member

No description provided.

@pentschev
Use weak_ptr<ucxx::Endpoint> in ErrorCallbackData
296f94e 
A race could cause the `Endpoint::errorCallback` to dereference an
already closed and destroyed `ucxx::Endpoint`, leading to segmentation
faults and sometimes deadlocks. With the use of a `weak_ptr<Endpoint>`
that can be prevented by returning before dereferencing the pointer
which should be safe since the owner has already been destroyed anyway.
@pentschev
EP cancel/non-blocking close
f4b7dc4
@pentschev
Allow querying inflight request count in ucxx::InflightRequests
230b81b
@pentschev
Allow querying inflight request count in ucxx::Endpoint
8641ec3
@pentschev
Add methods to initiate ucxx::Endpoint stop process
8f5d0b2
@pentschev
Add missing enablePythonFuture defaults
3c983c6
@pentschev
Fix missing status set in ucxx::Endpoint::closeBlocking()
e87baf5
@pentschev
Request fixes
3b22f54
@pentschev
Remove request from ucxx::InflightRequests canceling map
2d54ebd 
Additionally comment out use of `dropCanceled()` which is probably now
redundant but requires confirmation.
@pentschev
Do not track requests that completed immediately in cancelAll
27ac23f
@pentschev
Fix RequestEndpointClose force mode
a687988
@pentschev
Endpoint cancelation tests
dfe975e
@pentschev
Notify callback when all inflight/canceling requests complete
1fee6b4
@pentschev
Add user callback to ucxx::Endpoint::cancelInflightRequests()
4dc81c5
@pentschev
Endpoint test cancel inflight requests callback
0c2b72d
@pentschev
Use scoped_locks in ucxx::InflightRequests
82e6f5f
@pentschev
Print exception in callback warning message
15dbb91
@pentschev
Remove ucxx::InflightRequests::dropCanceled()
621abc4
@pentschev
ucxx::InflightRequests cleanup
981469a
@pentschev
Add missing rejection tests and improve comments
dfdcb90
@pentschev
Update ucxx::Endpoint::close() docstring
cef478b
@pentschev
Update ucxx::Requests comments and logging
5a72fe1
@pentschev
Merge remote-tracking branch 'upstream/branch-0.38' into non-blocking…
44cec65 
…-ep-close-cancel
@pentschev
Add missing callback in ucxx::Endpoint::removeInflightRequest
e0206f0
@pentschev
Add ucxx::Endpoint reference back to ucxx::EndpointErrorCallback
65671d2
@pentschev
Issue ucxx::Request::cancel() in worker thread when active
71a8f12
@pentschev
Remove inflight request if its status has been already set
21dd0a9
@pentschev
Keep track of ucxx::Request upon findAndRemove() return
6d113a3
@pentschev
Register ucxx::Endpoint during createRequestAm()
110c8d1
@pentschev
Check and reset `ucxx::Request::_cancelCallback
50072c1
@pentschev pentschev changed the base branch from branch-0.38 to branch-0.39 July 25, 2024 14:23
@pentschev pentschev changed the base branch from branch-0.39 to branch-0.40 July 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pentschev