Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add telemetry stuff for conda-cpp-build workflow #247

Draft
wants to merge 44 commits into
base: branch-24.12
Choose a base branch
from
Draft

add telemetry stuff for conda-cpp-build workflow #247

wants to merge 44 commits into from

Conversation

msarahan
Copy link
Contributor

This is being tested in:

When complete, this PR should add instrumentation to at least one workflow. More workflows can be adapted later once this is proven.

This is a draft PR until it is proven to be in working order. For cleanup, we'll also need to:

  • remove the gha-tools stuff that is pulling from my personal fork, and merge Add otel wrapper gha-tools#118 so the telemetry stuff is baked into ci-imgs.
  • Move the OpenTelemetry install steps here into ci-imgs

@msarahan msarahan mentioned this pull request Oct 3, 2024
Open
@msarahan msarahan force-pushed the add-telemetry branch 2 times, most recently from 4ba847f to 109c1e8 Compare October 9, 2024 23:21
@msarahan msarahan changed the base branch from branch-24.10 to branch-24.12 October 9, 2024 23:21
@msarahan
try to use msarahan/shared-actions repo actions
c953eed
@msarahan
change shared actions repo to rapidsai
8d7466c
@msarahan
fix branch for gha-tools clone
cc00864
@msarahan
update branch for shared-actions and gha-tools to main
71eac30
@msarahan
back to msarahan gha-tools for quoting issue
90f5d7b
@msarahan
put job name in OTEL_SERVICE_NAME
0490bc5
@msarahan
echo job info for debugging
59e3b41
@msarahan
Add step name and fix service name
358db71
@msarahan
remove fromJSON
ca83855
@msarahan
where is my name?
6754794
@msarahan
missing echo
9027f5c
@msarahan
unquote job-info?
25b96af
@msarahan
maybe echo syntax was wrong?
0ab31f8
@msarahan
github job name
b4bd3a8
@msarahan
use dedicated action for job name
c1f7812
@msarahan
add API rate limit check
bbbd083
@msarahan
remove rate limit check - did not work
cae090c
@msarahan
move job name script up to fail faster
ec7cfb5
@msarahan
move opentelemetry instrumentation lower, so other things fail sooner
4a9f601
@msarahan
change branch for telemetry-setup
e32e09d
@msarahan
add more workflows
08097da
@msarahan
telemetry in checks.yaml
93e74aa
@msarahan
move otel-cli download into shared-action
83a6652
@msarahan
add telemetry to more workflow files
552adb1
@msarahan
remove dangling mv otel-cli from conda-cpp-build
16c9796
@msarahan
remove telemetry from devcontainer build for now
4d2e29f
@msarahan
Specify job name by augmenting it with matrix values
a22b2f1
@msarahan
set JOB_NAME for checks jobs
4350532
@msarahan
make JOB_NAME a parameter to the custom job workflow
d239e92
@msarahan
manually pass JOB_NAME through because GHA job names are bizarre
1a1e76f
@msarahan
ensure that all jobs have name set. Extend test ones with additional …
6b22f69 
…values
@msarahan
pass job name as explicit parameter to telemetry-summarize
1810358
@msarahan
disable jinja2 tracing, for sake of noise
a34fddd
@msarahan
use OTEL_SERVICE_NAME instead of job name. Use env var to propagate e…
9bec056 
…ndpoint
@msarahan
fix missing default prefix for conda-python-tests and wheels-test
d8f805a
@msarahan
Set resource attributes for simpler querying
d3ce07c
@msarahan
remove OTEL_SERVICE_NAME manual job name passing
e4ecd8d
@msarahan
set OTEL_SERVICE_NAME using gh action
a308d4e
@msarahan
pass OTEL_SERVICE_NAME into C++ build job - but why?
636347f
@msarahan
remove OTEL_SERVICE_NAME for now
3128bdb
@msarahan msarahan force-pushed the add-telemetry branch 2 times, most recently from 75f085b to 4dd785b Compare October 18, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msarahan