Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New strict crossings multiply PIP algorithm #846

Draft
wants to merge 1 commit into
base: branch-23.02
Choose a base branch
from

Conversation

harrism
Copy link
Member

@harrism harrism commented Dec 8, 2022

Description

This PR is in progress (draft).

This is a modification of the CrossingsMultiply algorithm worked out by @harrism and @isVoid that avoids explicit collinearity checks and consistently treats points on the polygon boundary as outside. While CrossingsMultiply works by shooting an imaginary ray in the +X direction from the test point and computing the inequality that results in crossings, this modification tests against +X and -X rays simultaneously.

Currently failing one of the tests, need to investigate.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Dec 8, 2022
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant