Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main][forwardport] Add validation to Toleration and Affinitys Keys #459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main][forwardport] Add validation to Toleration and Affinitys Keys #459

wants to merge 1 commit into from
+570 −6

Conversation

thatmidwesterncoder
Copy link
Contributor

Issue: rancher/rancher#46402

Problem

Solution

CheckList

  • Test
  • Docs

@thatmidwesterncoder thatmidwesterncoder requested a review from a team as a code owner August 2, 2024 16:44
@prachidamle prachidamle requested review from ericpromislow and nflynt and removed request for a team October 17, 2024 19:21
@prachidamle
Copy link
Member

@thatmidwesterncoder Can we add label area/webhook to the ticket to make sure QA gets notified on the webhook change. cc @daviswill2

nflynt
nflynt previously approved these changes Oct 17, 2024
View reviewed changes
@thatmidwesterncoder
Merge pull request rancher#316 from thatmidwesterncoder/toleration_va…
6b3f920 
…lidation

Add validation to Toleration and Affinitys Keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow Awaiting requested review from ericpromislow

@nflynt nflynt Awaiting requested review from nflynt

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatmidwesterncoder @prachidamle @nflynt