chore: remove redundant steps in docker build #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
kind/enhancement
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
improve-dockerfile-build-time
branch
from
49e57a8
to
c9a8db1
Compare
There was a problem hiding this comment.
Shall we take the possibility to do the same in https://github.com/rancher/turtles/blob/main/exp/etcdrestore/Dockerfile#L37-L52? Otherwise, LGTM
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
improve-dockerfile-build-time
branch
from
cba4a9d
to
9ec15a2
Compare
furkatgofurov7
approved these changes
Oct 25, 2024
yiannistri
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We've added improvements to Dockerfile in other repositories rancher/cluster-api-provider-rke2#483 and https://github.com/rancher/clusterapi-forks/pull/7. Removing redundant steps during build reduces execution time considerably.
go buildhandles downloading dependencies sogo modsteps are redundant.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist: