Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[updatecli] Bump CAPI Provider RKE2 version #802

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[updatecli] Bump CAPI Provider RKE2 version #802

merged 1 commit into from
Oct 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2024 •
edited by salasberryfin
Loading

Bump CAPRKE2 version to v0.8.0

@github-actions github-actions bot requested a review from a team as a code owner October 24, 2024 02:19
@salasberryfin salasberryfin force-pushed the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch from 3b81da5 to ec62961 Compare October 24, 2024 07:44
furkatgofurov7
furkatgofurov7 previously approved these changes Oct 24, 2024
View reviewed changes
@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) October 24, 2024 08:31
@furkatgofurov7
Copy link
Contributor

@salasberryfin just noticed this: dependency versions auto-updated by updatecli in the config.yaml only currently, used in go.mod files as well. For example, CAPRKE2:

turtles/exp/etcdrestore/go.mod

Line 10 in f2d9579

github.com/rancher/cluster-api-provider-rke2 v0.7.0
.

I wonder if we need to add go.mod file update to it to keep the same version throughout the code?

@salasberryfin
Copy link
Contributor

Yes, I think it makes sense that we add updates to go.mod as well. The original version was only intended to check clusterctl config.

@furkatgofurov7
Copy link
Contributor

As discussed and agrreed offline:

  • CAPRKE2 v0.8.0 minor version cut on the works, once published, we need to bump to new version in this patch (in both config and go.mod files)

@furkatgofurov7 furkatgofurov7 changed the title [updatecli] Bump CAPI Providers versions [updatecli] Bump CAPRKE2 version to v0.8.0 Oct 24, 2024
@salasberryfin salasberryfin force-pushed the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch from ec62961 to d8fda5c Compare October 24, 2024 10:52
Danil-Grigorev
Danil-Grigorev previously approved these changes Oct 24, 2024
View reviewed changes
@salasberryfin salasberryfin force-pushed the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch from d8fda5c to 4d084d9 Compare October 24, 2024 15:01
@github-actions github-actions bot force-pushed the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch from 391cf3a to 81c0082 Compare October 25, 2024 02:20
@github-actions github-actions bot changed the title [updatecli] Bump CAPRKE2 version to v0.8.0 [updatecli] Bump CAPI Providers versions Oct 25, 2024
@furkatgofurov7
Copy link
Contributor

As discussed and agrreed offline:

  • CAPRKE2 v0.8.0 minor version cut on the works, once published, we need to bump to new version in this patch (in both config and go.mod files)

CAPRKE2 v0.8.0 minor release is published, let's bump it here

@salasberryfin salasberryfin force-pushed the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch 2 times, most recently from c19a28e to eb0469a Compare October 25, 2024 11:34
furkatgofurov7
furkatgofurov7 previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @salasberryfin 👍🏼

@salasberryfin salasberryfin changed the title [updatecli] Bump CAPI Providers versions [updatecli] Bump CAPI Provider RKE2 versions Oct 25, 2024
@salasberryfin salasberryfin changed the title [updatecli] Bump CAPI Provider RKE2 versions [updatecli] Bump CAPI Provider RKE2 version Oct 25, 2024
@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) October 25, 2024 11:35
@salasberryfin salasberryfin requested a review from a team October 25, 2024 11:35
@furkatgofurov7 furkatgofurov7 added area/dependency Issues or PRs related to dependency changes kind/chore labels Oct 25, 2024
yiannistri
yiannistri previously approved these changes Oct 25, 2024
View reviewed changes
@salasberryfin
chore: bump caprke2
0e19eff 
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
@salasberryfin salasberryfin force-pushed the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch from eb0469a to 0e19eff Compare October 25, 2024 12:22
@salasberryfin salasberryfin requested a review from a team October 25, 2024 12:23
@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) October 25, 2024 12:23
@furkatgofurov7 furkatgofurov7 merged commit 98f91c9 into main Oct 25, 2024
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the updatecli_main_de1864defccec55be9eca14576e5f510cb8e6dff35da988bd035728bd05d2e38 branch October 25, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiannistri yiannistri yiannistri approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@Danil-Grigorev Danil-Grigorev Danil-Grigorev left review comments

Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@furkatgofurov7 @salasberryfin @yiannistri @Danil-Grigorev