Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache e2e image builds #793

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

alexander-demicev
Copy link
Member

What this PR does / why we need it:

Cache e2e image builds

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@alexander-demicev alexander-demicev added the kind/bug Something isn't working label Oct 21, 2024
@alexander-demicev alexander-demicev requested a review from a team as a code owner October 21, 2024 14:25
salasberryfin
salasberryfin previously approved these changes Oct 21, 2024
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @alexander-demicev. Perhaps this may also help with adding RKE2 scenarios to short tests.

@salasberryfin
Copy link
Contributor

I'm now seeing some authentication errors when it tries to push the cache data to ghcr registry:

ERROR: error writing layer blob: unexpected status from POST request to https://ghcr.io/v2/rancher/turtles-e2e-cache/blobs/uploads/: 403 Forbidden

@furkatgofurov7
Copy link
Contributor

I'm now seeing some authentication errors when it tries to push the cache data to ghcr registry:

ERROR: error writing layer blob: unexpected status from POST request to https://ghcr.io/v2/rancher/turtles-e2e-cache/blobs/uploads/: 403 Forbidden

Yes, I also noticed it in the e2e tests here

@alexander-demicev
Copy link
Member Author

alexander-demicev commented Oct 22, 2024

@salasberryfin @furkatgofurov7 github uses my account crendentials to push cache to GCHR registry when running tests from the PR, I changed that to only push cache for nightly builds

Changed it to use github/cache action so we can use cache in any PR or E2E run

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it's nice that we can run it on PRs also.

@alexander-demicev alexander-demicev merged commit 91a5eee into rancher:main Oct 23, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the cachebuild branch October 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

Successfully merging this pull request may close these issues.

4 participants