Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decompressing gh tool in Dockerfile #6378

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein requested a review from a team as a code owner July 19, 2024 19:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.78%. Comparing base (d0bdeee) to head (e67a4e8).

❗ There is a different number of reports uploaded between BASE (d0bdeee) and HEAD (e67a4e8). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (d0bdeee) HEAD (e67a4e8)
unittests 3 1
inttests 3 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6378      +/-   ##
==========================================
- Coverage   25.23%   17.78%   -7.46%     
==========================================
  Files          33       32       -1     
  Lines        2829     2817      -12     
==========================================
- Hits          714      501     -213     
- Misses       2068     2273     +205     
+ Partials       47       43       -4     
Flag Coverage Δ
inttests ?
unittests 17.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galal-hussein galal-hussein merged commit f0ff812 into rancher:master Jul 19, 2024
7 checks passed
galal-hussein added a commit to galal-hussein/rke2 that referenced this pull request Jul 19, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein added a commit to galal-hussein/rke2 that referenced this pull request Jul 19, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein added a commit to galal-hussein/rke2 that referenced this pull request Jul 19, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
galal-hussein added a commit to galal-hussein/rke2 that referenced this pull request Jul 19, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
iamsarthakk pushed a commit to iamsarthakk/rke2 that referenced this pull request Aug 19, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants