Move from drone to Github Actions for 1.6 #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitulshah-suse
force-pushed
the
move-to-gha-1.6
branch
30 times, most recently
from
efdd5ca
to
022c1bc
Compare
mitulshah-suse
force-pushed
the
move-to-gha-1.6
branch
11 times, most recently
from
c3208d5
to
797644d
Compare
mitulshah-suse
requested review from
jiaqiluo,
kinarashah,
HarrisonWAffel and
snasovich
HarrisonWAffel
previously approved these changes
Jun 7, 2024
jiaqiluo
requested changes
Jun 7, 2024
mitulshah-suse
force-pushed
the
move-to-gha-1.6
branch
from
797644d
to
7fc13c0
Compare
HarrisonWAffel
approved these changes
Jun 10, 2024
jiaqiluo
approved these changes
Jun 10, 2024
kinarashah
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref issue: rancher/rancher#45377
resolv.conffile gets mounted with incorrect entries for dns which cannot be overridden directly. ref: https://github.com/rancher/rke/blob/release/v1.5/dind/dind.go#L77-L78rke removekept failing withdirectory not emptyerrors in docker. Updated the code to first stop the container and then remove it with a pause in between. ref: Can not remove container, directory not empty moby/moby#8203 (comment)