Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-2.10] Add new vsphere-cpi and vsphere-csi charts #4634

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

jiaqiluo
Copy link
Member

@jiaqiluo jiaqiluo commented Oct 22, 2024

rancher/rancher#46836
rancher/rancher#46837

This PR adds the following 2 new charts:

  • rancher-vsphere-cpi 105.0.0+up1.9.1
  • rancher-vsphere-csi 105.0.0+up3.3.1-rancher6

Both charts

  • are generated based on the same commit in the upstream repo to support k8s 1.31
  • update the catalog.cattle.io/rancher-version annotation to enable the chart for rancher v2.10.0+ only
  • update the chart version to a new major release line (105.x.x)

@jiaqiluo jiaqiluo requested a review from a team as a code owner October 22, 2024 22:54
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

1 similar comment
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@jiaqiluo jiaqiluo changed the title [2.10] Add new vsphere-cpi and vsphere-csi charts [dev-2.10] Add new vsphere-cpi and vsphere-csi charts Oct 22, 2024
@HarrisonWAffel HarrisonWAffel requested a review from a team October 24, 2024 16:43
@jiaqiluo jiaqiluo force-pushed the 210-vsphere branch 2 times, most recently from 52ecde0 to 771cfa2 Compare October 24, 2024 17:17
@HarrisonWAffel HarrisonWAffel requested a review from a team October 24, 2024 17:27
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link
Contributor

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided release.yaml comments are resolved; please count this approval if that's the only change done.

release.yaml Show resolved Hide resolved
release.yaml Show resolved Hide resolved
Copy link
Collaborator

@nicholasSUSE nicholasSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

If the Build CI passes, we are good.
I will be doing all of the forward-ports to v2.10 from the last 2 releases this week.

@jiaqiluo jiaqiluo merged commit 3861565 into rancher:dev-v2.10 Oct 24, 2024
10 checks passed
@jiaqiluo jiaqiluo deleted the 210-vsphere branch October 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants