-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-2.10] Add system-upgrade-controller 105.0.0 #4633
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - only one comment to potentially address (about missing version
) - others are more observations/kudos.
It's a bit weird to see chart version without +up...
part but I see logic here - we don't really have upstream chart to reference there. We could reference SUC version there but I can see reasons for both doing and not doing that.
packages/system-upgrade-controller/charts/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
rancher/rancher#46835
This PR adds the new chart:
Changes:
tolerations
andaffinity
sectionvalues.yaml
filecatalog.cattle.io/rancher-version
annotation to enable the chart for rancher v2.10.0+ onlyNext step:
CATTLE_SYSTEM_UPGRADE_CONTROLLER_CHART_VERSION
in thepackage/Dockerfile
andtests/v2/codecoverage/package/Dockerfile
file in rancher/rancher