Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-2.10] Add system-upgrade-controller 105.0.0 #4633

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

jiaqiluo
Copy link
Member

@jiaqiluo jiaqiluo commented Oct 22, 2024

rancher/rancher#46835

This PR adds the new chart:

  • system-upgrade-controller 105.0.0

Changes:

  • migrate the source chart from the rancher/system-chart repo to this repo as the former is deprecated
  • update the manifest for the system-upgrade-controller deployment to match the one in the upstream v0.14.2 tag except the tolerations and affinity section
  • update image tags in the values.yaml file
  • update the catalog.cattle.io/rancher-version annotation to enable the chart for rancher v2.10.0+ only
  • update the chart version to a new major release line (105.x.x)

Next step:

  • bump the env var CATTLE_SYSTEM_UPGRADE_CONTROLLER_CHART_VERSION in the package/Dockerfile and tests/v2/codecoverage/package/Dockerfile file in rancher/rancher

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@jiaqiluo jiaqiluo marked this pull request as ready for review October 22, 2024 23:47
@jiaqiluo jiaqiluo requested a review from a team as a code owner October 22, 2024 23:47
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@HarrisonWAffel HarrisonWAffel requested a review from a team October 23, 2024 20:05
Copy link
Contributor

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only one comment to potentially address (about missing version) - others are more observations/kudos.

It's a bit weird to see chart version without +up... part but I see logic here - we don't really have upstream chart to reference there. We could reference SUC version there but I can see reasons for both doing and not doing that.

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@jiaqiluo jiaqiluo merged commit 0420a47 into rancher:dev-v2.10 Oct 24, 2024
8 checks passed
@jiaqiluo jiaqiluo deleted the 210-suc branch October 24, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants