[dev-v2.9] prometheus-federator 104.0.2-rc.1+up0.4.2 update #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
mallardduck
force-pushed
the
29/prom-fed-bumps
branch
from
168039a
to
c0c8867
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
mallardduck
force-pushed
the
29/prom-fed-bumps
branch
from
c0c8867
to
2e1fcff
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
jbiers
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#47610
QA Testing Considerations
The shell image for this chart is used as part of
cleanupworkflows. As such to test it properly I believe the way to invoke it is by deleting a Project monitor which triggers cleanup job.Regressions Considerations
This shouldn't affect much for either change; one is just a technicality to fix false-positives and the other is making shell image tag match that of default for Rancher this chart targets.
Backporting considerations
This type of Patch needs to be applied to each version independently (not a clean back port). This PR is already a backport of equivalent improvements we've made for 2.10/main. I don't believe backport to 2.8 is a priority.