Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the syntax: the 'and' was missing.: #4429

Open
wants to merge 1 commit into
base: dev-v2.8
Choose a base branch
from
Open

Fix the syntax: the 'and' was missing.: #4429

wants to merge 1 commit into from
+1 −1

Conversation

ericpromislow
Copy link
Contributor

See issue #47092

This typo is in rancher-monitoring charts for v2.8 and v2.9

@ericpromislow ericpromislow requested a review from a team as a code owner September 12, 2024 21:55
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@mallardduck
Copy link
Member

Seems like we want to use #4449 in favor of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasSUSE nicholasSUSE Awaiting requested review from nicholasSUSE

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpromislow @mallardduck