Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for unmaintained ActiveSupport::Cache::RedisStore #625

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Remove support for unmaintained ActiveSupport::Cache::RedisStore #625

merged 5 commits into from
Oct 14, 2023

Conversation

mitchellhenke
Copy link
Contributor

As of January of last year, https://github.com/redis-store/redis-activesupport is no longer maintained. This PR removes the support for it from rack-attack.

grzuy
grzuy approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Agree it's safe to drop this.
There's been enough time to migrate to rails official RedisCacheStore.

Thanks!

@grzuy grzuy merged commit 9a7815c into rack:main Oct 14, 2023
80 checks passed
@mitchellhenke
Copy link
Contributor Author

Thank you so much for rack-attack, the quick fixes, and merge!

@mitchellhenke mitchellhenke deleted the remove-redis-activesupport-store branch October 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchellhenke @grzuy