Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge upstream 3.3.0 #23

Merged
merged 33 commits into from
Aug 28, 2023
Merged

Merge upstream 3.3.0 #23

merged 33 commits into from
Aug 28, 2023
+217 −21

Conversation

manicmaniac
Copy link
Member

@manicmaniac manicmaniac commented Aug 25, 2023 •
edited
Loading

Overview

All you need to see is 1da92e7

Screenshot

image

Kaspik and others added 30 commits August 27, 2020 11:03
@Kaspik
Fix building example app, fix assets, fix plist
94fd070
@Kaspik
Merge branch 'master' into exampleFix
3187e99
@Kaspik
Merge pull request MessageKit#1441 from MessageKit/exampleFix
f1ffd39 
Fix Example app merge issues #trivial
@Kaspik
Update IBAV dependency to 5.1.0 with dark mode support
e535c73
@Kaspik
Merge pull request MessageKit#1442 from MessageKit/ibav
3810e74 
Update IBAV to 5.1.0 with Dark Mode support #trivial
@amirpirzad
Add pan gesture
ddfce2e
@amirpirzad
Check pan gesture direction
57e77b0
@amirpirzad
Add message time label
216d26b
@amirpirzad
Add boolean for enable/disable display time
404f3ad
@amirpirzad
Add comment
5949d6e
@amirpirzad
Change text color for dark mode
72c4c21
@amirpirzad
Remove unused code
8f17474
@amirpirzad
Add removePanGesture method
f04a89c
@amirpirzad
Change to better check
c0a659d
@amirpirzad
Use system color
d4f0def
@amirpirzad
Use property
ad28df1
@amirpirzad
Fix center label
be2eea0
@bguidolim
Fixes MessageKit#1446 - Added LinkPreview calculator into the list of…
20c6044 
… default calculators.
@bguidolim
Added changelog entry
ceb557c
@Kaspik
Merge pull request MessageKit#1447 from bguidolim/fix-issue-1446
947b801 
Fixes MessageKit#1446 - Added LinkPreview calculator into the list of default calculators
@amirpirzad
Fix some issues
f08cdad
@amirpirzad
Conform protocol
d2b8777
@amirpirzad
Add document
c6bfdba
@Kaspik
Merge branch 'development' into development
d80dc20
@amirpirzad
Update CHANGELOG.md
d4c980a
@Kaspik @martinpucik
Update CHANGELOG.md
2fc4946 
Co-authored-by: Martin Púčik <martin.pucik@me.com>
@Kaspik
Merge pull request MessageKit#1444 from amirpirzad/development
ab794e1 
Display message time by swiping left
@Kaspik
Prepare release 3.3.0
81b2f6f
@Kaspik
Update MessagesDataSource.swift
0e27b92
@Kaspik
Merge pull request MessageKit#1453 from MessageKit/development
ae53cdd 
Prepare release 3.3.0
@manicmaniac manicmaniac self-assigned this Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

3 Warnings
⚠️ Sources/Layout/MessageSizeCalculator.swift#L112 - Function body should span 40 lines or less excluding comments and whitespace: currently spans 43 lines
function_body_length MessageSizeCalculator.swift:112
⚠️ Sources/Layout/MessagesCollectionViewFlowLayout.swift#L181 - Function should have complexity 10 or less: currently complexity equals 12
cyclomatic_complexity MessagesCollectionViewFlowLayout.swift:181
⚠️ Sources/Views/Cells/MessageContentCell.swift#L357 - Limit vertical whitespace to a single empty line. Currently 2.
vertical_whitespace MessageContentCell.swift:357

Generated by 🚫 Danger

manicmaniac
manicmaniac commented Aug 28, 2023
View reviewed changes
Sources/Controllers/MessagesViewController.swift
Comment on lines +481 to +482
// Since quipper/MessageKit does not use image caches, the next line is commented out.
// MessageStyle.bubbleImageCache.removeAllObjects()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in #22 (comment), MessageStyle enum is completely diverged from the original.
MessageStyle.bubbleImageCache does not exist in our version.

@manicmaniac manicmaniac marked this pull request as ready for review August 28, 2023 04:50
m-sugawara
m-sugawara approved these changes Aug 28, 2023
View reviewed changes
Copy link

@m-sugawara m-sugawara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

elliekwon
elliekwon approved these changes Aug 28, 2023
View reviewed changes
Copy link

@elliekwon elliekwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🚀

k-kohey
k-kohey approved these changes Aug 28, 2023
View reviewed changes
Copy link

@k-kohey k-kohey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manicmaniac manicmaniac merged commit ebe5c71 into master Aug 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sugawara m-sugawara m-sugawara approved these changes

@elliekwon elliekwon elliekwon approved these changes

@k-kohey k-kohey k-kohey approved these changes

Assignees

@manicmaniac manicmaniac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@manicmaniac @m-sugawara @elliekwon @k-kohey @Kaspik @amirpirzad @bguidolim