Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mlop-2456): add protection to host setting on cassandra_client #385

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

albjoaov
Copy link
Contributor

@albjoaov albjoaov commented Oct 11, 2024

What 🔧

  • Makefile: changes to exclude venv files from checks and formatting
  • Add _validate_and_format_cassandra_host and unit tests
  • tests/unit/butterfree/transform/transformations/conftest.py: fixing a test

@albjoaov albjoaov requested a review from a team as a code owner October 11, 2024 16:34
@@ -62,7 +62,7 @@ def target_df_spark(spark_context, spark_session):
"timestamp": "2016-04-11 11:31:11",
"feature1": 200,
"feature2": 200,
"feature__cos": 0.48718767500700594,
"feature__cos": 0.4871876750070059,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected value it is without this last number

Copy link

sonarcloud bot commented Oct 11, 2024

@albjoaov albjoaov merged commit ab551c0 into staging Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants