Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DIRECTIVE] Masked Input Directive #2513

Closed
wants to merge 25 commits into from
Closed

[DIRECTIVE] Masked Input Directive #2513

wants to merge 25 commits into from

Conversation

bloodf
Copy link
Contributor

@bloodf bloodf commented Sep 4, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR introduce a masked input directive. v-mask. It can receive an Array or masks or a string of a mask.

const TOKENS = {
  '#': { pattern: /[\x2A\d]/ },
  0: { pattern: /\d/ },
  9: { pattern: /\d/ },
  X: { pattern: /[0-9a-zA-Z]/ },
  S: { pattern: /[a-zA-Z]/ },
  A: { pattern: /[a-zA-Z]/, transform: v => v.toLocaleUpperCase() },
  a: { pattern: /[a-zA-Z]/, transform: v => v.toLocaleLowerCase() },
  '!': { escape: true }
}

Documentation -> quasarframework/quasar-framework.org#589

@rstoenescu
Copy link
Member

Hi,

Seems like a much needed & very good addition. Please ping me as soon as I come back from vacation so I won't forget about this. Thanks for your efforts!

@rstoenescu rstoenescu added this to the v1.0 milestone Sep 17, 2018
@rstoenescu
Copy link
Member

Hi,

Thank you for working on this. However, I chose a different path for v1.0, so closing this.

@rstoenescu rstoenescu closed this Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants