This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Added Quasar / Vue SFC example for debounce #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoidesic
changed the title
rstoenescu
suggested changes
May 27, 2018
| @@ -50,6 +50,23 @@ window.addEventListener( | |||
| ) | |||
| ``` | |||
|
|
|||
| Vue SFV example: | |||
| </template | ||
| <script> | ||
| export default { | ||
| import { debounce } from 'quasar' |
There was a problem hiding this comment.
import statement inside the export generates error. it should be outside of the exported object.
rstoenescu
reviewed
May 27, 2018
| export default { | ||
| import { debounce } from 'quasar' | ||
| methods: { | ||
| save: debounce(function(field, value) { |
There was a problem hiding this comment.
you're calling the "save" method with one parameter only (the value), but it's definition has two parameters, out of which the first one is the "field"
rstoenescu
reviewed
May 27, 2018
| Vue SFV example: | ||
| ``` | ||
| <template> | ||
| <q-input @keyup="save(submission)" v-model="submission" /> |
There was a problem hiding this comment.
for completeness, it would be better as @keyup="() => { save(submission) }
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch and not themasterbranchfix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: