Don't minify during development #593
Merged
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working in
apps/vscode/
currently kind of sucks because the debugging experience is suboptimal. Sourcemaps don't seem to be working right, causing the Debug Variables pane to show minified names, not real names. Stepping is also pretty jumpy.Turns out that we are minifying during our
dev
builds, which seems to be what is breaking things. It is also kind of weird right? We should only minify during production, not during development. That's also what VS Code's extension guide suggests:https://code.visualstudio.com/api/working-with-extensions/bundling-extension#run-esbuild
And what esbuild's guide says: "Usually you minify code in production but not in development."
https://esbuild.github.io/api/#minify
Before:
(Note how the variables pane has 1 letter names, and how it jumps over the if branch, seemingly without running it)
Screen.Recording.2024-10-30.at.12.00.24.PM.mov
After:
fixed.mov
In theory both VS Code and esbuild have all the required glue to make
minify + sourcemaps
work through thisnames
mapping field, but clearly something isn't working right:evanw/esbuild#1296
microsoft/vscode#12066