Use a Helm dependency for the search backend (OpenSearch) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #207 , because you supposedly can specify an ordering between dependencies and the main app.
It kind of makes sense to use an off-the-shelf k8s config for OpenSearch rather than rolling out our own anyway.
But... this doesn't work currently, there seems to be problems with overriding default values from dependency charts: helm/helm#12677, helm/helm#9027 (comment)
The exact behavior depends on the Helm version, so I need to look into that; I'll try upgrading to the latest version.
Opening as draft in the meantime.