Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple shell.nix to enable QMK toolchain in shell #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evantravers
Copy link

Solves: #8

Description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not everyone wants to use nix; this file should be removed. Feel free to add instructions in a comment in the shell.nix file, or some sort of associated readme that explains the setup procedure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nor does everybody run around with direnv — if I’d made that assumption we’d already have one with layout python3 so that we don’t have issues with system packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d prefer this go into a util/nix directory and instructions provided on how to enable it. Remember people have full control over their userspace repo; they can commit those to their fork after placing things in the right spot.

@budimanjojo
Copy link

Currently I have a flake.nix working locally and I don't use the qmk provided by the stable/unstable nixpkgs repo because they get outdated most of the time. So I use buildPythonApplication to build the package manually because it allows more control on the qmk version. The downside is needing to build the program in the environment and updating this file frequently is needed. But if you want to do it this way, I propose using the unstable branch instead of pinning it to 24.05. Because this will get outdated very fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants