Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use pinia for status store #1367

Merged
merged 7 commits into from
Nov 1, 2024
Merged

chore: use pinia for status store #1367

merged 7 commits into from
Nov 1, 2024

Conversation

yanfali
Copy link
Collaborator

@yanfali yanfali commented Oct 23, 2024

Description

  • port away from vuex to pinia
  • using the options api for now until everything is ported over
  • preparation for a vue3 port
  • fixed broken workflow so it passes again

 - port away from vuex to pinia
 - using the options api for now until everything is ported over
 - preparation for a vue3 port
 - fetch is this baseline now so it's safe to use in a browser
 - rename deferredMessage() to setDeferredMessage
 - initialize pinia for electron (probably should delete this code)
   - this fixes the electron based cypress test failures
@yanfali yanfali marked this pull request as ready for review October 23, 2024 21:56
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I can think to check still works.

Feel free to merge this if you're satisfied with current state.

@yanfali yanfali merged commit d0d00db into master Nov 1, 2024
2 checks passed
@yanfali yanfali deleted the pinia-port branch November 1, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants