fixed #13; commbined load_study.psp and check_job_status.psp #499
Conversation
| @@ -40,7 +40,34 @@ else: | |||
| raise('Could not determine job identifier. study_id and meta_analysis_id are both empty.') | |||
|
|
|||
| job_type_ids = form['job_type_id'].split(',') | |||
| # queued_data_load = form['queued_data_load'] | |||
There was a problem hiding this comment.
This will probably fail with a key error if it doesn't exist?
There was a problem hiding this comment.
So it is. hehe! I think I need a vacation...
There was a problem hiding this comment.
:-D
On Thu, Aug 15, 2013 at 3:17 PM, Doug Wendel notifications@github.comwrote:
In www/check_job_status.psp:
@@ -40,7 +40,34 @@ else:
raise('Could not determine job identifier. study_id and meta_analysis_id are both empty.')job_type_ids = form['job_type_id'].split(',')
+# queued_data_load = form['queued_data_load']So it is. hehe! I think I need a vacation...
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/499/files#r5801572
.
There was a problem hiding this comment.
If it's commented old/broken/unused code, it should be deleted
|
What was the motivation for refactoring? |
|
to dynamically load "queued date to load" section and reduce code redundancy On Thu, Aug 15, 2013 at 2:38 PM, Doug Wendel notifications@github.comwrote:
|
|
@RNAer is the main goal of this pull request to factor out the contents of these files? Or are you adding/removing some specific functionality we should check for (I cannot see anything, but it's worth asking). |
|
Actually both. It fixed #13 and also reduce code redundancy. No On Wed, Oct 16, 2013 at 12:54 PM, Yoshiki Vázquez Baeza <
|
No description provided.