Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QgsAdvancedDigitizingTools): Add precision (decimals) to Circle D… #59155

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

lbartoletti
Copy link
Member

Description

Precision is everywhere, but not always the same, and sometimes there isn't any.
Here, as it's in the same perimeter, I suggest adding the same number of decimals as for CadTool.

Capture d'écran 2024-10-21 104915

Fixes: #59039

@lbartoletti lbartoletti self-assigned this Oct 21, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Oct 21, 2024
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit af45a38)

@lbartoletti lbartoletti merged commit 372ab66 into qgis:master Oct 21, 2024
30 of 31 checks passed
@lbartoletti lbartoletti deleted the set_decimals_circle_distance branch October 21, 2024 09:59
@uclaros
Copy link
Contributor

uclaros commented Oct 21, 2024

Erm, the bug report was about X and Y fields, which are the ones you usually need more precision on, not distance!

Also note that the tool will not work correctly for geographic CRSs mentioned in the bug report and it should probably be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2-Circle Point Intersection coordinate precision problem
3 participants