Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override checkParameterValues() method in align rasters processing algorithm #59153

Merged

Conversation

benwirf
Copy link
Contributor

@benwirf benwirf commented Oct 21, 2024

Description

This PR re-implements the checkParameterValues() method in the native:alignrasters algorithm which was ported to a C++ processing algorithm in #53874. There have been a couple of reported issues (#57096 & #57102) since it may not be obvious to the user that output files need to be configured for each input raster.

There was also a recent question on GIS Stack Exchange along the same lines, so evidently this is still something which is confusing for some users.

There have also been a couple of previous PRs (#57127 & #57143- now stale) based on adding details to the algorithm help string and tool tips, which could also complement the approach proposed here.

This PR takes a slightly more 'forceful' approach since the execution of the algorithm will be blocked and a (hopefully) informative message will be shown to the user.

*I am not 100% on the wording of the message so feedback/ suggestions are welcome.

align-rasters

Screenshot from 2024-10-21 12-33-10

…gorithm

to ensure that output files have been configured for all input rasters.
@github-actions github-actions bot added this to the 3.40.0 milestone Oct 21, 2024
Copy link

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit b1a3fab)

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nyalldawson nyalldawson merged commit ce35c42 into qgis:master Oct 21, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants