Override checkParameterValues() method in align rasters processing algorithm #59153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gorithm to ensure that output files have been configured for all input rasters.
🪟 Windows buildsDownload Windows builds of this PR for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-implements the
checkParameterValues()method in thenative:alignrastersalgorithm which was ported to a C++ processing algorithm in #53874. There have been a couple of reported issues (#57096 & #57102) since it may not be obvious to the user that output files need to be configured for each input raster.There was also a recent question on GIS Stack Exchange along the same lines, so evidently this is still something which is confusing for some users.
There have also been a couple of previous PRs (#57127 & #57143- now stale) based on adding details to the algorithm help string and tool tips, which could also complement the approach proposed here.
This PR takes a slightly more 'forceful' approach since the execution of the algorithm will be blocked and a (hopefully) informative message will be shown to the user.
*I am not 100% on the wording of the message so feedback/ suggestions are welcome.