-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style constraint save when strength is NotSet #58986
Fix style constraint save when strength is NotSet #58986
Conversation
@nyalldawson this fixes the issue #58431 but not the root cause and I'd like an opinion about the possibility to change The current behavior is not consistent. |
cb175d5
to
df947ef
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
It's too long ago for me to remember exactly, but I suspect this was done in order to preserve API (ie before the introducing of soft constraints, all constraints where implicitly "hard" but we weren't explicitly tracking that). I'm happy for you to tweak this logic as needed -- there's good test coverage there, so I'm confident we'll be alerted if you break anything in the process.. |
Fix qgis#58431 I feel that the underlying issue remains (which is that setting the strength to NotSet removes it from the field but not from the layer and that the default strength is Hard) but since it was clearly made in purpose 8 years ago I am not keen to change it lightly.
b0e9d50
to
e67e777
Compare
Fix #58431
I feel that the underlying issue remains (which is that setting the strength to NotSet removes it from the field but not from the layer and that the default strength is Hard) but since it was clearly made in purpose 8 years ago I am not keen to change it lightly.