Fix flat terrain implementation

qgis · Oct 28, 2024 · 00c35d1 · 00c35d1
1 parent 2b7cfa6
commit 00c35d1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/3d/chunks/qgschunkloader.cpp b/src/3d/chunks/qgschunkloader.cpp
@@ -51,7 +51,7 @@ QVector<QgsChunkNode *> QgsQuadtreeChunkLoaderFactory::createChildren( QgsChunkN
   for ( int i = 0; i < 4; ++i )
   {
     int dx = i & 1, dy = !!( i & 2 );
-    const QgsChunkNodeId childId( nodeId.d + 1, nodeId.x * 2 + dx, nodeId.y * 2 + ( dy ? 0 : 1 ) );  // TODO: inverse dy?
+    const QgsChunkNodeId childId( nodeId.d + 1, nodeId.x * 2 + dx, nodeId.y * 2 + dy );
 
     const double chXMin = dx ? center.x() : box3D.xMinimum();
     const double chXMax = dx ? box3D.xMaximum() : center.x();

diff --git a/src/3d/terrain/qgsflatterraingenerator.cpp b/src/3d/terrain/qgsflatterraingenerator.cpp
@@ -77,7 +77,7 @@ Qt3DCore::QEntity *FlatTerrainChunkLoader::createEntity( Qt3DCore::QEntity *pare
   const double yMin = commonExtent.yMinimum() - map->origin().y();
 
   transform->setScale3D( QVector3D( xSide, 1, ySide ) );
-  transform->setTranslation( QVector3D( xMin + xSide / 2, 0, yMin + ySide / 2 ) );
+  transform->setTranslation( QVector3D( xMin + xSide / 2, 0, -( yMin + ySide / 2 ) ) );
 
   createTextureComponent( entity, map->isTerrainShadingEnabled(), map->terrainShadingMaterial(), !map->layers().empty() );