Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to doNd and plot_id #166

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

ThorvaldLarsen
Copy link
Collaborator

@ThorvaldLarsen ThorvaldLarsen commented Dec 28, 2018

Making a few changes for the new dataset functions in qdev_wrappers.

Changes in this PR:

  • Save arrayparameters as blobs rather than individual points
  • change write_period to 1s (liveplotting refresh time)
  • Change save_image to take data_id as input to allow use outside doNd functions
  • Move save_image to plotting_tools
  • Make simple tranformation functions for plotting. This will be replaced by a more intuitive version in the future.
  • Add progressbar as implemented by Estaban in Live plotting and sweep functions #111.

This PR requires microsoft/Qcodes#1430

@WilliamHPNielsen @jenshnielsen @nataliejpg

- Fix a few bugs related to array parameters
- Change save image to take dataid rather than datasaver object. This allows one to use save_image outside doNd funcitons
Add functionality to plot_by_id
- Subtract average from row/column,
- transpose data

Move save_image to plotting file instead of doNd
get_label doesnt work on colorbar object.
@ThorvaldLarsen
Copy link
Collaborator Author

@WilliamHPNielsen I added the transformation functions here. Also removed the copy of plot_by_id.

@nataliejpg
Copy link
Collaborator

is there an example notebook with any of these things in? I think that would be really valuable in general but especially in moments like this it would make it really quick to see the functionality. Otherwise sounds really good and we are definitely very keen for the row/column average tool!

@ThorvaldLarsen
Copy link
Collaborator Author

@nataliejpg I have added an example notebook for plotting. There is already one for doNd which I think is still up to date - this PR only fixes some bugs in doNd not their functionality.

@ThorvaldLarsen ThorvaldLarsen changed the title Changes to doNd and plot_by_id Changes to doNd and plot_id Jan 23, 2019
@ThorvaldLarsen
Copy link
Collaborator Author

@jenshnielsen when you get a chance, can you take a quick look at this and maybe merge it? Only thing not working is multiple arrayparameters of different size, which I believe is also not working without this update to doNd functions.

@nataliejpg
Copy link
Collaborator

i like it a lot. I would add the gluing datasets together as something desirable but also see no reason not to go ahead with this merge in the meantime.

@ThorvaldLarsen
Copy link
Collaborator Author

@jenshnielsen this PR has been tested quite a bit at T3. Any chance we can merge it?

@jenshnielsen
Copy link
Contributor

@ThorvaldLarsen I pushed up the changes to unify the progessbar with the rest of qcodes. I think this is ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants