Refactor loss plumbing #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmarx
commented
Jun 15, 2022
•
dmarx
commented
- eliminated superflous TargetImage constructor
- cleanup debugging statements
- wherever possible, init tensors on devices instead of transferring
|
TargetImage constructor deprecation should be good to go, should clean out some debugging messages and maybe also unnecessary(?) device assignments that were added after 96eaae2. |
dmarx
force-pushed
the
refactor_loss_plumbing
branch
2 times, most recently
from
5ec3e59
to
e31fbf8
Compare
…starting computer and reinstalling torch
…d z translation to test, all passing. TO DO: document this edge case with a failing test
dmarx
force-pushed
the
refactor_loss_plumbing
branch
from
e31fbf8
to
d0bf637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.