Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly C++11 ABI builds #8307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add nightly C++11 ABI builds #8307

wants to merge 1 commit into from

Commits on Oct 23, 2024

  1. Add nightly C++11 ABI builds

    Initially, PyTorch/XLA was built with C++11 ABI, which was a more modern
    ABI (e.g. small string optimizations). However, that conflicts with the
    ABI of upstream PyTorch, so #5650
    disabled the C++11 ABI. It turns out that C++11 ABI improves LazyTensor
    tracing performance drastically for some large models. We can't go back
    to C++11 ABI due to conflict with upstream, so this PR adds additional
    nightly build variants that enable C++11 ABI next to the existing wheels
    and dockers.
    
    The docker images will be tagged like "nightly_3.10_tpuvm_cxx11_20241023"
    instead of "nightly_3.10_tpuvm_20241023".
    
    The wheels will be named like
    "torch_xla-2.6.0.dev20241023.cxx11-cp310-cp310-linux_x86_64.whl" instead
    of "torch_xla-2.6.0.dev20241023-cp310-cp310-linux_x86_64.whl".
    
    This PR also adds support for building C++11 ABI variants for stable
    branches, but we don't activate it yet.
    
    This PR also removes Python 3.8 nightly builds.
    
    Fixes #8306.
    tengyifei committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7c5cc22 View commit details
    Browse the repository at this point in the history