Fix support for torch.var_mean.
#8275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default argument `correction=None` did not match the Torch API (default 1) and wasn't supported by the Jax API (where it's not nullable). Changing the default to 1 fixed the failing test case. Issue: pytorch#7542
|
To clarify, Actually, I should probably add the safety check inside the function definition. That way, it will still work if Torch ever changes its implementation such that |
added 2 commits
October 17, 2024 13:51
Torch doesn't ever explicitly pass `correction=None` into the implementation of `var_mean`, but the API does technically specify that it's nullable. Therefore, we add a null check just to be safe. Issue: pytorch#7542
For consistency with the following `var` call, and because `axis` is officially a keyword argument, change the `mean` call to pass `axis=dim` as a keyword argument instead of a positional argument. Issue: pytorch#7542
|
I added that |
qihqi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default argument
correction=Nonedid not match the Torch API (default 1) and wasn't supported by the Jax API (where it's not nullable). Changing the default to 1 fixed the failing test case.Issue: #7542