enable linalg.vector_norm tests #8249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* for ord==0 case typecast back to the input type
barney-s
commented
Oct 10, 2024
| @@ -1290,7 +1290,8 @@ def _aten_linalg_vector_norm(self, ord=2, dim=None, keepdim=False, dtype=None): | |||
| # Special cases (for efficiency and clarity) | |||
| if ord == 0: | |||
| if self.shape == (): | |||
| result = jnp.array(float(self != 0)) | |||
| # float sets it to float64. set it back to input type | |||
| result = jnp.astype(jnp.array(float(self != 0)), self.dtype) | |||
There was a problem hiding this comment.
without this the failure seen was:
FAILED test/test_ops.py::TestOpInfoCPU::test_reference_eager_linalg_vector_norm_cpu_float32 - AssertionError: The values for attribute 'dtype' do not match: torch.float64 != torch.float32.
anishfish2
pushed a commit
to anishfish2/xla
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable linalg.vector_norm tests
fixes: #7505
ref: #7505 (comment)