Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue: Op info test for cdist #7400
Right now the test is not passing locally:
The fail error in more detail:
However the issue arises from fp arithmetic, as I ran an example to test the closeness of values:
Expected Result (PyTorch): tensor([[3.1193, 2.0959],
[2.7138, 3.8322],
[2.2830, 0.3791]])
Your Result (JAX): [[3.1192703 2.0958931]
[2.7138407 3.8321724]
[2.2830095 0.3791012]]
Can someone help me fix this precision error? Other than that this Op is ready to be merged I think.