Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version check for FSDP2 recipe #1162

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Add version check for FSDP2 recipe #1162

merged 4 commits into from
Jul 11, 2024

Conversation

ebsmothers
Copy link
Contributor

Add a check that users have at least PyTorch 2.4 installed to run FSDP2 recipe

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1162

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 10b5e21 with merge base a129b55 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2024
joecummings
joecummings reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment at the top of the config files too?

@ebsmothers
Copy link
Contributor Author

Can you add a comment at the top of the config files too?

I think they're already in there, just needed to pull from latest main

@ebsmothers ebsmothers merged commit c9f99f6 into pytorch:main Jul 11, 2024
29 checks passed
@ebsmothers ebsmothers deleted the fsdp2-pt-version-check branch July 11, 2024 22:38
pbontrager pushed a commit that referenced this pull request Jul 11, 2024
@ebsmothers
Add version check for FSDP2 recipe (#1162)
7e7392b
maximegmd pushed a commit to maximegmd/torchtune that referenced this pull request Jul 13, 2024
@ebsmothers @maximegmd
Add version check for FSDP2 recipe (pytorch#1162)
0ccf213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings joecummings left review comments

@kartikayk kartikayk kartikayk approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ebsmothers @joecummings @kartikayk @facebook-github-bot