Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchcodec] Fix bug where we were not finding the best audio stream #64

Closed
wants to merge 1 commit into from
Closed

[torchcodec] Fix bug where we were not finding the best audio stream #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/torchcodec/decoders/_core/VideoDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void VideoDecoder::initializeDecoder() {
if (bestVideoStream >= 0) {
containerMetadata_.bestVideoStreamIndex = bestVideoStream;
}
int bestAudioStream = getBestStreamIndex(AVMEDIA_TYPE_VIDEO);
int bestAudioStream = getBestStreamIndex(AVMEDIA_TYPE_AUDIO);
if (bestAudioStream >= 0) {
containerMetadata_.bestAudioStreamIndex = bestAudioStream;
}
Expand Down
2 changes: 1 addition & 1 deletion test/decoders/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def test_get_video_metadata():
metadata = get_video_metadata(decoder)
assert len(metadata.streams) == 6
assert metadata.best_video_stream_index == 3
assert metadata.best_audio_stream_index == 3
assert metadata.best_audio_stream_index == 4

with pytest.raises(NotImplementedError, match="TODO: decide on logic"):
metadata.duration_seconds
Expand Down
Loading