[torchcodec] new core function, get_frames_in_range #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58904069 |
|
This pull request was exported from Phabricator. Differential Revision: D58904069 |
|
This pull request was exported from Phabricator. Differential Revision: D58904069 |
Summary: Pull Request resolved: #47 Implementation of new core function. Python signature: ``` get_frames_in_range( decoder: torch.Tensor, * stream_index: int, begin: int, end: int, step: Optional[int] = None ) -> torch.Tensor ``` It returns a stacked tensor in exactly the same manner as `get_frames_at_indices`. We're adding this function to support slices in `SimpleVideoDecoder`. (That implementation is coming next.) To support this new core function, this diff: * Adds a new C++ member function, `VideoDecoder::getFramesInRange()` which does the real work. It follows the same form as `VideoDecoder::getFramesAtIndexes()`. * Adds the plumbing to expose `get_frames_in_range()` as a core function. * Modifies the resource generation script to add new test files. We need ranges of frames now. * Adds the binary resource files. Reviewed By: ahmadsharif1 Differential Revision: D58904069
|
This pull request was exported from Phabricator. Differential Revision: D58904069 |
|
This pull request has been merged in b56b999. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implementation of new core function. Python signature:
It returns a stacked tensor in exactly the same manner as
get_frames_at_indices. We're adding this function to support slices inSimpleVideoDecoder. (That implementation is coming next.) To support this new core function, this diff:VideoDecoder::getFramesInRange()which does the real work. It follows the same form asVideoDecoder::getFramesAtIndexes().get_frames_in_range()as a core function.Differential Revision: D58904069