Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the wheel, install it on a separate machine, run the tests. Profit. #30

Closed
wants to merge 12 commits into from

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jun 14, 2024

This PR adds the following jobs to our OSS CI:

  • Build a wheel (these are the same wheel(s) that would be updated on PyPI eventually)
  • Save that wheel as an artifact (see actions/upload-artifact@v4)
  • Spin up a new machine, download the wheel that was previously built
  • Install torchcodec from that wheel: that's exactly what users will eventually do when they pip install torchcodec from PyPI
  • Install FFmpeg - this can be done at any point, but we do it here to ensure there's no build/install dependency on FFmpeg
  • Run the torchcodec tests to ensure the wheel installation went fine.

If this works, it means we're 90% done with the packaging on x86 Linux.

There is some overlap with the already-existing "Unit Test / python" job. I think we can get rid of those, but I'll leave that for a follow-up PR.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 14, 2024
@NicolasHug NicolasHug changed the title Build wheel, install it, test it. Build the wheel, install it on a separate job, test it. Profit. Jun 14, 2024
@NicolasHug NicolasHug changed the title Build the wheel, install it on a separate job, test it. Profit. Build the wheel, install it on a separate machine, run the tests. Profit. Jun 14, 2024
@NicolasHug NicolasHug marked this pull request as ready for review June 14, 2024 16:56
@facebook-github-bot
Copy link
Contributor

@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NicolasHug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NicolasHug merged this pull request in 1bc888d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants