Install cuda-enabled torchvision #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
huydhn
pushed a commit
to pytorch/test-infra
that referenced
this pull request
Oct 25, 2024
Without this there would be cache collisions of different default-packages. i.e. the symptom I was seeing was the cache would restore my conda environment but without the packages. I tested it here with torchcodec pytorch/torchcodec#298 https://github.com/pytorch/torchcodec/actions/runs/11523232397/job/32081186451?pr=298 And it seems to be working fine. Example the cache key contains the package hashes: <img width="1193" alt="image" src="https://github.com/user-attachments/assets/f04d6ac9-ff72-4f07-b5ef-831b6d3fd09f">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise I sometimes see torchvision CPU changing the underlying torch version which removes critical cuda libraries and we see test failures:
https://github.com/pytorch/torchcodec/actions/runs/11517533038/job/32062818448?pr=294
Note that I had to use my own fork of test-infra until pytorch/test-infra#5821 is merged into main. I'll update this to use main once pytorch/test-infra#5821 is merged.