Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for the user to pass in ffmpeg thread count #291

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ahmadsharif1
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 commented Oct 24, 2024

This can control the number of FFMPEG threads and can improve throughput if num_threads=1 is used (which is the default now).

For a comprehensive benchmark analysis look at this:

https://github.com/ahmadsharif1/torchcodec/blob/bench1/README.md#benchmark-results

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 24, 2024
@ahmadsharif1 ahmadsharif1 marked this pull request as ready for review October 24, 2024 20:01
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahmadsharif1 !

src/torchcodec/decoders/_video_decoder.py Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants