Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torchcodec] stream_index should not be optional for getting frame by index #24

Closed
wants to merge 1 commit into from
Closed

[torchcodec] stream_index should not be optional for getting frame by index #24

wants to merge 1 commit into from

Commits on Jun 18, 2024

  1. [torchcodec] stream_index should not be optional for getting frame by… 

    … index (#24)

Summary:
Pull Request resolved: #24

Making `stream_index` optional on `get_frame_by_index()` and `get_frames_by_indices()` was a mistake. The C++ method we're calling, `VideoDecoder::getFrameAtIndex()` and `VideoDecoder::getFramesAtIndexes()` needs the actual stream index. It can't take -1 as the default as I had assumed.

Reviewed By: NicolasHug

Differential Revision: D58505608
    @scotts @facebook-github-bot
    scotts authored and facebook-github-bot committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ceee642 View commit details
    Browse the repository at this point in the history