Skip to content

Commit

Permalink
Add comment as per review
Browse files Browse the repository at this point in the history
  • Loading branch information
NicolasHug committed Jun 14, 2024
1 parent 0ae80bc commit adcd2ba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def get_ext_filename(self, fullname):
# FFmpeg. We don't know what FFmpeg version that is, so we build
# `libtorchcodec.so` without any version suffix.
# If BUILD_AGAINST_INSTALLED_FFMPEG is not set then we want to build against all
# ffmpeg major version.
# ffmpeg major version that are available on our S3 bucket.
FFMPEG_MAJOR_VERSIONS = (
("",) if os.getenv("BUILD_AGAINST_INSTALLED_FFMPEG") is not None else (4, 5, 6, 7)
)
Expand Down
3 changes: 2 additions & 1 deletion src/torchcodec/decoders/_core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ else()
message(
STATUS
"Building and dynamically linking libtorchcodec against our pre-built
non-GPL FFmpeg libraries"
non-GPL FFmpeg libraries. These libraries are only used at build time,
you still a different need FFmpeg to be installed for run time!"
)

# This will expose the ffmpeg4, ffmpeg5, ffmpeg6, and ffmpeg7 targets
Expand Down

0 comments on commit adcd2ba

Please sign in to comment.